Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.08%. Comparing base (2b23a03) to head (36c4671).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #9612      +/-   ##
==========================================
+ Coverage   88.01%   88.08%   +0.07%     
==========================================
  Files         177      177              
  Lines       22350    22356       +6     
==========================================
+ Hits        19671    19692      +21     
+ Misses       2679     2664      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk Any idea why tests/unit/test_plugin_manager.py::TestPluginManager::test_get_nodes is failing across all Python versions here?

Do we also need to update https://github.com/dbt-labs/dbt-core/blob/main/core/setup.py#L88-L97?

Any idea why tests/unit/test_plugin_manager.py::TestPluginManager::test_get_nodes is failing across all Python versions here?

Discussed offline: It was surprising that the test passed in the first place with called_once_with, because there were always multiple calls to the tracking module, each with num_models as 1 (not 2, as the test was previous passing). Switching to assert_called_once_with on this branch actually brought this issue to light. We confirmed no actual change in behaviour across the branches and updated the test to be more precise / accurate using assert_has_calls

Do we also need to update main/core/setup.py#L88-L97?

Done, thanks!

I noticed that part of the acceptance criteria was to ensure that bundles can be created with Python 3.12. Should we confirm that before merging this?

I noticed that part of the acceptance criteria was to ensure that bundles can be created with Python 3.12. Should we confirm that before merging this?

How would you recommend I do this? I intended to merge this PR in, backport the change to 1.7, then test the created bundle for 1.7 with Python 3.12.

I intended to merge this PR in, backport the change to 1.7, then test the created bundle for 1.7 with Python 3.12.
Sounds great! 💪

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-9612-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b337e0b7263a01648028958dc3da3a145767b12b
# Push it to GitHub
git push --set-upstream origin backport-9612-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-9612-to-1.7.latest.